The panko.hacking.checks Module

Guidelines for writing new hacking checks

  • Use only for Panko specific tests. OpenStack general tests should be submitted to the common ‘hacking’ module.

  • Pick numbers in the range X3xx. Find the current test with the highest allocated number and then pick the next value.

  • Keep the test method code in the source file ordered based on the C3xx value.

  • List the new rule in the top level HACKING.rst file

panko.hacking.checks.factory(register)
panko.hacking.checks.no_log_warn(logical_line)

Disallow ‘LOG.warn(‘

https://bugs.launchpad.net/tempest/+bug/1508442

C301

panko.hacking.checks.no_os_popen(logical_line)

Disallow ‘os.popen(‘

Deprecated library function os.popen() Replace it using subprocess https://bugs.launchpad.net/tempest/+bug/1529836

C302